chore(bidi): Handle headers properly in BiDi network.continueRequest #34268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
juliandescottes
force-pushed
the
bidi-continueRequest-headers
branch
from
3f48f4e to
06361bf
Compare
juliandescottes
force-pushed
the
bidi-continueRequest-headers
branch
from
06361bf to
b6da487
Compare
Test results for "tests 1"7 flaky37545 passed, 648 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers should be converted to valid bidi request headers.
Should fix the following tests with bidi:
page/page-request-continue.spec.ts :: continue should delete headers on redirects
page/page-request-continue.spec.ts :: continue should propagate headers to redirects
page/page-request-continue.spec.ts :: propagate headers cross origin redirect after interception